Use Maturin directly for building distributions#755
Merged
Conversation
sdispater
force-pushed
the
refactor/use-maturin
branch
4 times, most recently
from
298df30 to
7dc71ef
Compare
CodSpeed Performance ReportMerging #755 will not alter performanceComparing Summary
|
sdispater
force-pushed
the
refactor/use-maturin
branch
5 times, most recently
from
a1978b4 to
37b1409
Compare
sdispater
force-pushed
the
refactor/use-maturin
branch
from
37b1409 to
0ca9ce3
Compare
2 tasks
RCoeurjoly
added a commit
to RCoeurjoly/poetry2nix
that referenced
this pull request
Oct 21, 2024
RCoeurjoly
added a commit
to RCoeurjoly/poetry2nix
that referenced
this pull request
Oct 23, 2024
cpcloud
pushed a commit
to RCoeurjoly/poetry2nix
that referenced
this pull request
Oct 28, 2024
cpcloud
pushed a commit
to cpcloud/poetry2nix
that referenced
this pull request
Oct 28, 2024
Arkptz
pushed a commit
to Arkptz/poetry2nix
that referenced
this pull request
Nov 2, 2024
|
@sdispater This has broken it for systems without Rust :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to make Poetry and Maturin work together proved too cumbersome.
This PR makes all the distributions building go trough Maturin directly. This required to use PEP-621 metadata declaration and will cause duplication with Poetry own metadata declaration for a while.
Pull Request Check List